My C program - Help me in identifying anything wrong with it

[xiao_xiao]

---

@chaosorb: bacn required sa ila mag-gamit ug function. natingala pud ko sa TS nganong redundant iya getch();

[MarkCuering]

"Create a pseudocode, flowchart and C program that ask the user 2 integer numbers. The user then enters another character in order to choose which operator to perform: A - addition, S - subtraction, M - multiplication, D- division. Create separate functions for each operation."

[SmaRkieS]

@chaosorb: bacn required sa ila mag-gamit ug function. natingala pud ko sa TS nganong redundant iya getch();

ana dyud na xiao basta gikan sa teachers, gamiton ang getch(); para mo pause.

[SmaRkieS]

to TS, below is my take on your program. I'm not sure if this will run, but more or less, its the appropriate solution.

TIPS
*KISS(keep it short and simple)
-avoid using too many variables
-avoid using unnecessary functions
-recycle variables if necessary

#include <stdio.h>
#include <conio.h>

int main() {
  int a, b;
  char c;
  
  clrscr();
  printf("Enter value for 1st number: ");
  scanf("%i",&a);
  printf("Enter value for 2nd number: ");
  scanf("%i",&b);
  
  printf("\nChoices:\n\t[A]ddition\n\t[S]ubtraction\n\t[M]ultiplication\n\t[D]ivision\nSelect: ");
  c = getche();
  
  if(c=='A'){
    printf("The sum of %i and %i is %i",a, b, (a+b));
  }
  if(c=='S'){
    printf("The difference of %i and %i is %i",a,b,(a-b));
  }
  if(c=='M'){
    printf("The product of %i and %i is %i",a,b,(a*b));
  }
  if(c=='D'){
    printf("The quotient of %i and %i is %6.2f",a,b,(a/b));
  }
  getch();
} 

critic to your hearts content

Compiling....

Mo exit ang program after selecting choice D or d.

Answered na ni sa post #18

[xiao_xiao]

kung pseudocode basihan sayop japon kang smarkies... dapat i-input daan ang integers before choices. hehe

gika ra ni kang smarkies... gi-change lng nako ang order sa pag input... base sa pseudocode...

#include<stdio.h>
#include<conio.h>
int add(int, int);
int subtract(int, int);
float divide(int, int);
int multiply(int, int);

main(void)
{
 int a, b, d, e, f;
 float g;
 char c;
 clrscr();

 printf("\nEnter two integers separated by a space: ");
 scanf("%d %d", &a, &b); 

 printf("Select an operation:\n(A) Add\n(S) Subtract\n(D) Divide\n(M) Multiply\n");
 printf("Choice: ");
 scanf("%c",&c); 

 if (c=='A')
 {
  d=add(a, b);
  printf("The sum of %d and %d is %d", a, b, d);
  getch();
 }

 if (c=='S')
 {
  e=subtract(a, b);
  printf("The difference of %d and %d is %d", a, b, e);
  getch();
 }

 if (c=='D')
 {
  g=divide(a, b);
  printf("The quotient of %d and %d is %.2f", a, b, g);
  getch();
 }

 if (c=='M')
 {
  f=multiply(a, b);
  printf("The product of %d and %d is %d", a, b, f);
  getch();
 }
 getch();

}


int add(int a, int b)
{
 return (a+b);
}
int subtract(int a, int b)
{
 return (a-b);
}
int multiply(int a, int b)
{
 return (a*b);
}
float divide(int a, int b)
{
 return ((float)a/b);
} 

[xiao_xiao]

ana dyud na xiao basta gikan sa teachers, gamiton ang getch(); para mo pause.

i mean kanang ok ra mn cguro kung isa ra ka getch();
didto sa last part ra ka magbutang.

[harryperales]

@harryperales: ok ra mn yata iyang function prototypes...

ang standard C programs nag-require na cya nga ang imong function prototype including sa iyang parameters should be the same as the one on the function declaration.

[xiao_xiao]

mudagan mn japon...
bacn good programming practice lng cguro nga butngan ug variable ang parameters.

[marcdaven]

Mga bro, salamat kaayo sa inyong pagtabang! I'll see which corrected nga programs nako ang pwede nako magamit.

Ask lang diay ko, unsa ang gamit sa getche()?

(PS: Using katong code with getche() ang naka pa work sa program diay so far.. Pero hadlok man ko mugamit sa getche() nga command oi kay magduda nya ang maestra namo ngano kahibaw ko mugamit ana nga wala man siya nagtudlo ana.. )

[marcdaven]

gika ra ni kang smarkies... gi-change lng nako ang order sa pag input... base sa pseudocode...

#include<stdio.h>
#include<conio.h>
int add(int, int);
int subtract(int, int);
float divide(int, int);
int multiply(int, int);

main(void)
{
 int a, b, d, e, f;
 float g;
 char c;
 clrscr();

 printf("\nEnter two integers separated by a space: ");
 scanf("%d %d", &a, &b); 

 printf("Select an operation:\n(A) Add\n(S) Subtract\n(D) Divide\n(M) Multiply\n");
 printf("Choice: ");
 scanf("%c",&c); 

 if (c=='A')
 {
  d=add(a, b);
  printf("The sum of %d and %d is %d", a, b, d);
  getch();
 }

 if (c=='S')
 {
  e=subtract(a, b);
  printf("The difference of %d and %d is %d", a, b, e);
  getch();
 }

 if (c=='D')
 {
  g=divide(a, b);
  printf("The quotient of %d and %d is %.2f", a, b, g);
  getch();
 }

 if (c=='M')
 {
  f=multiply(a, b);
  printf("The product of %d and %d is %d", a, b, f);
  getch();
 }
 getch();

}


int add(int a, int b)
{
 return (a+b);
}
int subtract(int a, int b)
{
 return (a-b);
}
int multiply(int a, int b)
{
 return (a*b);
}
float divide(int a, int b)
{
 return ((float)a/b);
} 

@xiao: muungot man gihapon siya inig input nako sa desired choice nako.. then gitry nako nga walay getch() sa mga if statements, the same problem man gihapon.. T_T

#include<stdio.h>
#include<conio.h>
int add(int, int);
int subtract(int, int);
float divide(int, int);
int multiply(int, int);

main(void)
{
 int a, b, d, e, f;
 float g;
 char c;
 clrscr();

 printf("Select an operation:\n(A) Add\n(S) Subtract\n(D) Divide\n(M) Multiply\n");
 printf("Choice: ");
 scanf("%c",&c);

 printf("\nEnter two integers separated by a space: ");
 scanf("%d %d", &a, &b);

 if (c=='A')
 {
  d=add(a, b);
  printf("The sum of %d and %d is %d", a, b, d);
  getch();
 }

 if (c=='S')
 {
  e=subtract(a, b);
  printf("The difference of %d and %d is %d", a, b, e);
  getch();
 }

 if (c=='D')
 {
  g=divide(a, b);
  printf("The quotient of %d and %d is %.2f", a, b, g);
  getch();
 }

 if (c=='M')
 {
  f=multiply(a, b);
  printf("The product of %d and %d is %d", a, b, f);
  getch();
 }
 getch();

}


int add(int a, int b)
{
 return (a+b);
}
int subtract(int a, int b)
{
 return (a-b);
}
int multiply(int a, int b)
{
 return (a*b);
}
float divide(int a, int b)
{
 return ((float)a/b);
}  

@smarkies: Kani nga program hinuon, muwork ni pero pseudocode namo kay dapat maguna ang input of integers before sa choice sa operation.

float e; <-- use for what?
printf("The quotient of %d and %d is %d", a, b, g); <-- how you output floating point numbers?

Sayup ko ani bro.. Ang e variable kay para sa subtract diay na nga function.. Dapat wala na diay toy float variable declaration within sa if function sa divide.