My C program - Help me in identifying anything wrong with it

[marcdaven]

---

Guys, naa miy assignment sa among IT class. Ang question kay:

"Create a pseudocode, flowchart and C program that ask the user 2 integer numbers. The user then enters another character in order to choose which operator to perform: A - addition, S - subtraction, M - multiplication, D- division. Create separate functions for each operation."

Sample run:
Enter two integers: 10,5
Choices:
(A) Addition
(S) Subtraction
(M) Multiplication
(D) Division
Choice: M
The product is 50

Mao ni ang code nga nahimo nako. Nagdiscuss na man mi sugod sa mga control statements, and naa pa mi sa IF controlled loop. The program ran perfectly sa Turbo C diri sa balay namo pero dili siya mu print sa choice and sa answer.

#include<stdio.h>
#include<conio.h>
int add(int, int);
int subtract(int, int);
float divide(int, int);
int multiply(int, int);
void main(void)
{
 int a, b, d, e, f;
 float g;
 char c;
 clrscr();
 printf("Enter two integers separated by a space:\n");
 scanf("%d %d", &a, &b);
 printf("Actions:\n(A) Add\n(S) Subtract\n(D) Divide\n(M) Multiply\n");
 printf("Choice:\n");
 scanf("%c", &c);
 if (c=='A')
 {
  d=add(a, b);
  printf("The sum of %d and %d is %d", a, b, d);
  getch();
 }
 if (c=='S')
 {
  e=subtract(a, b);
  printf("The difference of %d and %d is %d", a, b, e);
  getch();
 }
 if (c=='D')
 {
  float e;
  g=divide(a, b);
  printf("The quotient of %d and %d is %d", a, b, g);
  getch();
 }
 if (c=='M')
 {
  f=multiply(a, b);
  printf("The product of %d and %d is %d", a, b, f);
  getch();
 }
 getch();
}
int add(int a, int b)
{
 return (a+b);
}
int subtract(int a, int b)
{
 return (a-b);
}
int multiply(int a, int b)
{
 return (a*b);
}
float divide(int a, int b)
{
 return ((float)a/b);
}

(PS: I don't know if this is allowed here sa forums. I just don't have anyone to guide me what's wrong with my code.. Check lang ko ni nga thread later sa gabii kay magclase sa ko )

Thanks!

[TEDA]

bai. pwede rmn xguro wala ni xla
int add(int a, int b)
{
return (a+b);
}
int subtract(int a, int b)
{
return (a-b);
}
int multiply(int a, int b)
{
return (a*b);
}
float divide(int a, int b)
{
return ((float)a/b);
}

then drtso nlng qa sa imung statements bah nga naai opertaion
then if else para sa imung division para sa katung divisor ug dividen
then imung multiplcation kai if else pd para sa kanang if mu input ug 0

[xiao_xiao]

isulod mn tingale imo mga functions like add, subtract, etc... sa main function.

imo kay...

void main(void) {
...
}
int add(int a, int b) {
...
}

isulod cguro sa main imo mga functions...

void main(void) {
   int add(int a, int b){
      //your code here
   }
}

[xyberblue]

isulod mn tingale imo mga functions like add, subtract, etc... sa main function.

imo kay...

void main(void) {
...
}
int add(int a, int b) {
...
}

isulod cguro sa main imo mga functions...

void main(void) {
   int add(int a, int b){
      //your code here
   }
}

Java mana nga style sa coding bro...
Ok ra ang pagkahimutang sa mga functions sa code sa TS.

[xiao_xiao]

murag mao mn gud to akong nahinumduman kitong ga csc101 ko sauna... isulod tanan sa main functions... especially sa mga old compilers like turbo/borland c/c++... dli ko sure nuon. hehe

or probably daghan kaayo ka ug getch...

ani ra cguro...

void main(void) {

   if (c=='A')
   {
     d=add(a, b);
     printf("The sum of %d and %d is %d", a, b, d);     
   }
   
   getch();
}

pwede ra mn cguro sa last part ra ka mag getch();

[xyberblue]

Guys, naa miy assignment sa among IT class. Ang question kay:

"Create a pseudocode, flowchart and C program that ask the user 2 integer numbers. The user then enters another character in order to choose which operator to perform: A - addition, S - subtraction, M - multiplication, D- division. Create separate functions for each operation."

Sample run:
Enter two integers: 10,5
Choices:
(A) Addition
(S) Subtraction
(M) Multiplication
(D) Division
Choice: M
The product is 50

Mao ni ang code nga nahimo nako. Nagdiscuss na man mi sugod sa mga control statements, and naa pa mi sa IF controlled loop. The program ran perfectly sa Turbo C diri sa balay namo pero dili siya mu print sa choice and sa answer.

#include<stdio.h>
#include<conio.h>
int add(int, int);
int subtract(int, int);
float divide(int, int);
int multiply(int, int);
void main(void)
{
 int a, b, d, e, f;
 float g;
 char c;
 clrscr();
 printf("Enter two integers separated by a space:\n");
 scanf("%d %d", &a, &b);
 printf("Actions:\n(A) Add\n(S) Subtract\n(D) Divide\n(M) Multiply\n");
 printf("Choice:\n");
 scanf("%c", &c);
 if (c=='A')
 {
  d=add(a, b);
  printf("The sum of %d and %d is %d", a, b, d);
  getch();
 }
 if (c=='S')
 {
  e=subtract(a, b);
  printf("The difference of %d and %d is %d", a, b, e);
  getch();
 }
 if (c=='D')
 {
  float e;
  g=divide(a, b);
  printf("The quotient of %d and %d is %d", a, b, g);
  getch();
 }
 if (c=='M')
 {
  f=multiply(a, b);
  printf("The product of %d and %d is %d", a, b, f);
  getch();
 }
 getch();
}
int add(int a, int b)
{
 return (a+b);
}
int subtract(int a, int b)
{
 return (a-b);
}
int multiply(int a, int b)
{
 return (a*b);
}
float divide(int a, int b)
{
 return ((float)a/b);
}

(PS: I don't know if this is allowed here sa forums. I just don't have anyone to guide me what's wrong with my code.. Check lang ko ni nga thread later sa gabii kay magclase sa ko )

Thanks!

Naa ra diri imo sayop TS:

input:
Enter two integers: 10,5
wrong implementation:

printf("Enter two integers separated by a space:\n");
 scanf("%d %d", &a, &b);

Dili masulod sa a and b variables ang 10 ug 5 ani imo implementation.

To simplify, why won't you let user to input 1st number then scanf, then second number then scanf?
Input:
Enter first integer: 10
Enter 2nd integer: 5

Implementation:

printf("Enter first integer:\n");
scanf("%d", &a);
printf("Enter second integer:\n");
scanf("%d", &b);

If you really want to implement this input: "Enter two integers: 10,5", then you have to store this input into string which is declared as char* then you have to parse that string to get 10 and 5 separately from the string which I think complicated pa sa imo part since wala pamo naabot ana nga level sa inyo topic karon. Better use what I suggested to simplify things for you.

[xiao_xiao]

hmmm... i think it's because ga comma ka sa imong input..
it should be 10 5... not 10, 5 because sa imong scanf kay walay comma ang "%d %d" nimo

[xiao_xiao]

sa imong sample run ga comma ka

Sample run:
Enter two integers: 10,5

sa imong code kay ga ingon ka nga seperated by space dapat

printf("Enter two integers separated by a space:\n");

[SmaRkieS]

Gi try nako ang imong program ari siya ma sangit, kay nangutana ka daan sa value for int a and b, then dili ma sulod.

Naa koy lain nga gi program nako try lang nako if pwedi ni nimo.

#include<stdio.h>
int sum(void);
int diff(void);
int prod(void);
int quot(void);

main(){
    char ch;
    do{
    clrscr();
    puts("a. Addition");
    puts("b. Subtraction");
    puts("c. Multiplication");
    puts("d. Division");
    puts("e. Exit Program");
    printf("\nSelect Choice (a,b,c,d,e): ");
    scanf("%c",&ch);
    if (ch=='a') printf("\nSum = %d",sum());
    else if (ch=='b') printf("\nDifference = %d",diff());
    else if (ch=='c') printf("\nProduct = %d",prod());
    else if (ch=='d') printf("\nQuotient = %d",quot());
    getch();
    }
    while (ch!='e');
}


int sum(void){
    int num1,num2,total;
    printf("\nEnter the first number  : "); scanf("%d",&num1);
    printf("Enter the sencond number: "); scanf("%d",&num2);
    total = num1 + num2;
    return total;
}
int diff(void){
    int num1,num2,total;
    printf("\nEnter the first number : "); scanf("%d",&num1);
    printf("Enter the second number: "); scanf("%d",&num2);
    total = num1 - num2;
    return total;
}
int prod(void){
    int num1,num2,total;
    printf("\nEnter the first number : "); scanf("%d",&num1);
    printf("Enter the second number: "); scanf("%d",&num2);
    total = num1 * num2;
    return total;
}
int quot(void){
    int num1,num2,total;
    printf("\nEnter the first number: "); scanf("%d",&num1);
    printf("Enter the second numer: "); scanf("%d",&num2);
    total = num1 / num2;
    return total;
}

[MarkCuering]

#include <stdio.h>

int main(int argc, char *argv[])
{

    int a, b;

     printf("Enter two integers separated by a space: ");
     scanf("%d %d", &a,&b);
    printf("%d, %d\n", a,b);

    return 0;

} 

OUTPUT:

Enter two integers separated by a space: 15 77
15, 77
Press any key to continue...