My C program - Help me in identifying anything wrong with it

[SmaRkieS]

---

@xiao

ambot asa ni gikan ani, ang gi input niya kay with spaces pero ang iyang gi pa output kay with comma, instead gi ingon samples sa TS kay with comma ang input, mas maayo if buhat nalang siya ug full program.

#include <stdio.h>

int main(int argc, char *argv[])
{

    int a, b;

     printf("Enter two integers separated by a space: ");
     scanf("%d %d", &a,&b);
    printf("%d, %d\n", a,b);

    return 0;

} 

OUTPUT:

[harryperales]

int add(int, int);
int subtract(int, int);
float divide(int, int);
int multiply(int, int);

sayop imong function prototypes above, it should match the function declarations nimo so the correct one should be

int add(int a, int b);
int subtract(int a, int b);
float divide(int a, int b);
int multiply(int a, int b);

Another thing

scanf("%c", &c);

do not use scanf when dealing with characters and strings kay naa jud cya tendency mo skip sa input nga part, resulta wala madawat nga value ang nag hulat sa output gkan sa scanf(). Use the code below instead

c=getche();

HERE's THE COMPLETE WORKING CODE

#include<stdio.h>
#include<conio.h>

int add(int a, int b);
int subtract(int a, int b);
float divide(int a, int b);
int multiply(int a, int b);

void main(void)
{
 int a, b, d, e, f;
 float g;
 char c;
 clrscr();
 
 printf("Enter two integers separated by a space:\n");
 scanf("%d %d", &a, &b);
 printf("Actions:\n(A) Add\n(S) Subtract\n(D) Divide\n(M) Multiply\n");
 printf("Choice: ");
 c=getche();
 
 if (c=='A')
 {
  d=add(a, b);
  printf("The sum of %d and %d is %d", a, b, d);
  getch();
 }
 if (c=='S')
 {
  e=subtract(a, b);
  printf("The difference of %d and %d is %d", a, b, e);
  getch();
 }
 if (c=='D')
 {
  g=divide(a, b);
  printf("The quotient of %d and %d is %f", a, b, g);
  getch();
 }
 if (c=='M')
 {
  f=multiply(a, b);
  printf("The product of %d and %d is %d", a, b, f);
  getch();
 }
 getch();
}
int add(int a, int b)
{
 return (a+b);
}
int subtract(int a, int b)
{
 return (a-b);
}
int multiply(int a, int b)
{
 return (a*b);
}
float divide(int a, int b)
{
 return ((float)a/b);
}

GOOD LUCK

[MarkCuering]

do not use scanf when dealing with characters and strings kay naa jud cya tendency mo skip sa input nga part, resulta wala madawat nga value ang nag hulat sa output gkan sa scanf().

getche() is another way to achieved, but allow me to introduced the advance way.

try:

scanf("%d%*[^\n]% %d%*[^\n]%", &a, &b);

[xiao_xiao]

@harryperales: ok ra mn yata iyang function prototypes...

[MarkCuering]

@xiao

ambot asa ni gikan ani, ang gi input niya kay with spaces pero ang iyang gi pa output kay with comma, instead gi ingon samples sa TS kay with comma ang input, mas maayo if buhat nalang siya ug full program.

The problem is that if you call scanf() to get some input, the newline is still left hanging around in the buffer and the rest of the characters. any leftover from stdin will be carried out on the next call.

see my previous code for some sort of trick.

[SmaRkieS]

already answered on my post #18

[MarkCuering]

already answered on my post #18

 if (c=='D')
 {
  float e;
  g=divide(a, b);
  printf("The quotient of %d and %d is %.2f", a, b, g);
  getch();
 } 

remove the line "float e;"

[xiao_xiao]

gi compare na ko ang code ni smarkies ug TS... murag ang difference ra lagi kay sa TS kay void main(void) tapos kang smarkies kay main(void). hehe.. mao ra to? sakto ba ko smarkies?

[SmaRkieS]

Yes xiao ako ra gi remove ang uban then gi balhin pud nako ang input sa 2 integers.. Running naman ang program tua sa gi post nako sa Post #18. Naa napud screen shots sa result.

[ChaosOrb]

to TS, below is my take on your program. I'm not sure if this will run, but more or less, its the appropriate solution.

TIPS
*KISS(keep it short and simple)
-avoid using too many variables
-avoid using unnecessary functions
-recycle variables if necessary

#include <stdio.h>
#include <conio.h>

int main() {
  int a, b;
  char c;
  
  clrscr();
  printf("Enter value for 1st number: ");
  scanf("%i",&a);
  printf("Enter value for 2nd number: ");
  scanf("%i",&b);
  
  printf("\nChoices:\n\t[A]ddition\n\t[S]ubtraction\n\t[M]ultiplication\n\t[D]ivision\nSelect: ");
  c = getche();
  
  if(c=='A'){
    printf("The sum of %i and %i is %i",a, b, (a+b));
  }
  if(c=='S'){
    printf("The difference of %i and %i is %i",a,b,(a-b));
  }
  if(c=='M'){
    printf("The product of %i and %i is %i",a,b,(a*b));
  }
  if(c=='D'){
    printf("The quotient of %i and %i is %6.2f",a,b,(a/b));
  }
  getch();
} 

critic to your hearts content