My C program - Help me in identifying anything wrong with it

[marcdaven]

---

revised...
getch() na akong gamit, dili na getche... tapos case insensitive na.

#include<stdio.h>
#include<conio.h>
int add(int, int);
int subtract(int, int);
float divide(int, int);
int multiply(int, int);

int main()
{
 int a, b, d, e, f;
 float g;
 char c;
 
 printf("Enter two integers separated by a space: ");
 scanf("%d %d", &a, &b);

 printf("Select an operation:\n(a) Add\n(s) Subtract\n(d) Divide\n(m) Multiply\n");
 printf("Choice: ");
 scanf("%c",&c);

 c = getch();

 if (c=='a' || c=='A')
 {
  d=add(a, b);
  printf("\nThe sum of %d and %d is %d\n", a, b, d);  
 }

 if (c=='s' || c=='S')
 {
  e=subtract(a, b);
  printf("\nThe difference of %d and %d is %d\n", a, b, e);  
 }

 if (c=='d' || c=='D')
 {
  g=divide(a, b);
  printf("\nThe quotient of %d and %d is %.2f\n", a, b, g);  
 }

 if (c=='m' || c=='M')
 {
  f=multiply(a, b);
  printf("\nThe product of %d and %d is %d\n", a, b, f);  
 }

 getch();
 return 0;
}


int add(int a, int b)
{
 return (a+b);
}
int subtract(int a, int b)
{
 return (a-b);
}
int multiply(int a, int b)
{
 return (a*b);
}
float divide(int a, int b)
{
 return ((float)a/b);
} 

Working ni bro pero di lang siya muprint sa letter of choice...

[xiao_xiao]

sad to say... c = getche(); jud imo gamiton. hehe

[SmaRkieS]

marc nag gamit namo ug else if? kay basin pud mahibung teacher nimo aning operation

if (c=='a' || c=='A')

so try nako balik na sa 2nd ang input of integers and using void.

testing...............

mao gihapon ma drop ang program inig input sa choice of operation, you can still modify the program with void main(void).

Naa man to explanation ani ngano dili pwedi e una, kalimot lang ko when I was 1st yr college pa sa CIT.

[xiao_xiao]

I've got a solution kung gusto jud ka ug c = getch();

#include<stdio.h>
#include<conio.h>
int add(int, int);
int subtract(int, int);
float divide(int, int);
int multiply(int, int);

int main()
{
 int a, b, d, e, f;
 float g;
 char c;
 
 printf("Enter two integers separated by a space: ");
 scanf("%d %d", &a, &b);

 printf("Select an operation:\n(A) Add\n(S) Subtract\n(D) Divide\n(M) Multiply\n");
 printf("Choice: ");
 scanf("%c",&c);

 c = getch();

 if (c=='a' || c=='A')
 {
  d=add(a, b);
  printf("%c\nThe sum of %d and %d is %d\n", c, a, b, d);  
 }

 if (c=='s' || c=='S')
 {
  e=subtract(a, b);
  printf("%c\nThe difference of %d and %d is %d\n", c, a, b, e);  
 }

 if (c=='d' || c=='D')
 {
  g=divide(a, b);
  printf("%c\nThe quotient of %d and %d is %.2f\n", c, a, b, g);  
 }

 if (c=='m' || c=='M')
 {
  f=multiply(a, b);
  printf("%c\nThe product of %d and %d is %d\n", c, a, b, f);  
 }

 getch();
 return 0;
}


int add(int a, int b)
{
 return (a+b);
}
int subtract(int a, int b)
{
 return (a-b);
}
int multiply(int a, int b)
{
 return (a*b);
}
float divide(int a, int b)
{
 return ((float)a/b);
} 

notice the changes...

printf("%c\nThe sum of %d and %d is %d\n", c, a, b, d); 

printf("%c\nThe sum of %d and %d is %d\n", c, a, b, d);

[marcdaven]

Naa man to explanation ani ngano dili pwedi e una, kalimot lang ko when I was 1st yr college pa sa CIT.

Lage bro, gi try man pud toh nako ang imong program nga mag una ang integers. Mu exit lage gihapon inig butang sa choice of operations. T_T Muwork lang jud siya if maguna ang choice of operation.

Well, maybe dili jud nato masunod ang sample run nga gihatag sa among maestra pero at least, nakuha nato ang expected outcome using simple codes.

Ay, wala pa diay mi nag discuss sa else if. IF ra jud iyang gusto makit-an.

[marcdaven]

I've got a solution kung gusto jud ka ug c = getch();

printf("%c\nThe sum of %d and %d is %d\n", c, a, b, d); 

printf("%c\nThe sum of %d and %d is %d\n", c, a, b, d);

Ngano naa may %c after sa open quotations? Unsa man effect ani using getch();?

[xiao_xiao]

kung c = getch(); imong gamiton kay dili mn mugawas ang letter of choice...
so ang solution kay isagol na lng nimo sa output.

otherwise kung dili ka ganahan ani printf("%c\nThe sum of %d and %d is %d\n", c, a, b, d);
balik ka sa c = getche() tapos balik pud ka to printf(\nThe sum of %d and %d is %d\n", a, b, d);

[SmaRkieS]

marc, based on my experience sa una some teachers malipay or gahana nga mag una ang studyante (feeling expert) just to prove them nag self study ka, aw noon sa una nag self study dyud ko most of my vacant time naa sa library (nag baha ang mga books sa CIT) extra time mag practice, extra time mag babewatch, extra time mag tulog tulog.

Pero sunda lang sa ang instructions sa imong teacher ang flow sa inyong discussion ba basin ma shock imong teacher where ka anang mga codes nga wala pa ma discuss.

If linya dyud nimo ang computer then interesado dyud ka ug programming, ask your teacher if pwedi ba mag self study. Para kung mag discuss, most of the time mo ask man dyud na ang teacher to volunter to solve a program to the black board without any aid of computer, maka impress dyud baya.

May unta gi sabay ang inyong flow charting and programming, kay gamit dyud kaayo na ang duha.

May gani na save pa nako akong mga projects, activities and, exam programs.

[xiao_xiao]

marc, trust me. ok ra ng mag-gamit ug getche() ui. over na sad na inyong teacher kung dili mo pagamiton ana. hehe. peace.
gipagamit mn gani mo ug getch().. igsoon ra ng ng getch() ug getche(). hehe
getch() = get character.
getche = get character ewan. haha

basta ang getche() kay i-print niya imong gi-press na keyboard character.

[ChaosOrb]

getch() - get character without echo
getche() - get character with echo