My C program - Help me in identifying anything wrong with it

[xiao_xiao]

---

c = getch() version... hehe.. saonz..

#include<stdio.h>
#include<conio.h>
int add(int, int);
int subtract(int, int);
float divide(int, int);
int multiply(int, int);

void main(void)
{
 int a, b, d, e, f;
 float g;
 char c;
 
 printf("Enter two integers separated by a space: ");
 scanf("%d %d", &a, &b);

 printf("Select an operation:\n(A) Add\n(S) Subtract\n(D) Divide\n(M) Multiply\n");
 printf("Choice: ");
 scanf("%c",&c);

 c = getch();

 if (c=='a' || c=='A')
 {
  d=add(a, b);
  printf("%c\nThe sum of %d and %d is %d\n", c, a, b, d);  
 }

 if (c=='s' || c=='S')
 {
  e=subtract(a, b);
  printf("%c\nThe difference of %d and %d is %d\n", c, a, b, e);  
 }

 if (c=='d' || c=='D')
 {
  g=divide(a, b);
  printf("%c\nThe quotient of %d and %d is %.2f\n", c, a, b, g);  
 }

 if (c=='m' || c=='M')
 {
  f=multiply(a, b);
  printf("%c\nThe product of %d and %d is %d\n", c, a, b, f);  
 }

 getch(); 
}


int add(int a, int b)
{
 return (a+b);
}
int subtract(int a, int b)
{
 return (a-b);
}
int multiply(int a, int b)
{
 return (a*b);
}
float divide(int a, int b)
{
 return ((float)a/b);
} 

c = getche() version. lol

#include<stdio.h>
#include<conio.h>
int add(int, int);
int subtract(int, int);
float divide(int, int);
int multiply(int, int);

void main(void)
{
 int a, b, d, e, f;
 float g;
 char c;
 
 printf("Enter two integers separated by a space: ");
 scanf("%d %d", &a, &b);

 printf("Select an operation:\n(A) Add\n(S) Subtract\n(D) Divide\n(M) Multiply\n");
 printf("Choice: ");
 scanf("%c",&c);

 c = getche();

 if (c=='a' || c=='A')
 {
  d=add(a, b);
  printf("\nThe sum of %d and %d is %d\n", a, b, d);  
 }

 if (c=='s' || c=='S')
 {
  e=subtract(a, b);
  printf("\nThe difference of %d and %d is %d\n", a, b, e);  
 }

 if (c=='d' || c=='D')
 {
  g=divide(a, b);
  printf("\nThe quotient of %d and %d is %.2f\n", a, b, g);  
 }

 if (c=='m' || c=='M')
 {
  f=multiply(a, b);
  printf("\nThe product of %d and %d is %d\n", a, b, f);  
 }

 getch(); 
}


int add(int a, int b)
{
 return (a+b);
}
int subtract(int a, int b)
{
 return (a-b);
}
int multiply(int a, int b)
{
 return (a*b);
}
float divide(int a, int b)
{
 return ((float)a/b);
} 

[xiao_xiao]

nahimuot mn ko ui... naabot na ta ug page 5. hehe

[doomsweek]

Nganong void main() man jd? int main() is the correct declaration man daw according to The C FAQ.

Unya use getche() nalang. Aig kahadlok sa imong maestra. Haha. They already know na most students mo research jd na sa internet for their assignments. D nana mahibung nganong nakahibaw ka ug getche() as long as you know what it does.

i found out nga case sensitive ang compiler so instead of if(c=='A'), use if(c=='a')...

Yep case sensitive na since A and a are two different things. 'A' is 65 while 'a' is 97.

[xiao_xiao]

int main() mn ako example at first peru ana ang TS nga void main() daw ganahan sa iyang maestra.

[doomsweek]

int main() mn ako example at first peru ana ang TS nga void main() daw ganahan sa iyang maestra.

I was referring to the topic starter.

Pangutana sad sa imong maestra unsay reason why void main() and iyang gpagamit. Don't blindly believe in what they say or teach. I had one teacher that had a demo in front of our class that went wrong and blamed it all on a virus on his laptop, when in fact he just forgot to enable a certain setting to make it work.

[MarkCuering]

LOL... nice discusson for basic calculation hehehehe

[markytrigger]

magloop man cguro ka kung unsa ang giinput then mag swithch ka nindot ang loop kay mag cge dagan imu program

[xiao_xiao]

@markytrigger: wla pa mn tingale ga discuss ilang teacher anang for loop ug switch.
as for now, kung unsa pay gitudlo sa teacher, mao sa ilang gamiton.

[drixx101]

try daw before every scanf add ug flushall();
nyah instead of making a lot of if statements, himoa ug if-else if kay aron one time ra magcheck imu program if mkuha na niya ang desired choice.

and also c = getchar(); para makita nimo ang choice nga giinput

also ayaw nlng himo ug functions for add, subtract, multiply and divide, dretsoa nlng..the shorter the code the better,,

and try this:

if(toupper(c) == 'A')
{
//imong statements
}

toupper(c) is a function nga muconvert sa charcter to its uppercase form, by this, pwede ra muinput ang user bisan dili big letter kay iconvert naman na niya dretso..

..and para maresolve n inyo conflict sa void main(void), mao na xa ang declaration because ang main function does not return anything, and wala pud ipass nga parameters sa main, that's why void main(void).. pwede man pud nang int main(void), pero magbutang ka ug return 0; sa end sa main function, w/c is dugang npd sa code confusion..

[SmaRkieS]

ka complicated na gud ug mga suggestions ninyo, hehehe hagbay naman ni na human (page 2 post 1, kilangan ra niya simple nga program according to their discussions sa skul. Na pass nani sa iyang teacher.