PHP Newbie: patabang ko to simplify a simple code :)

[Metz]

---

ga self study ko ug PHP right now. Total newbie ko about programming.
I would like to ask the experts for suggestions in how to make my code simpler.


The Challenge:
Write a program, in any free language, that prints to the terminal the lyrics to 99 Bottles of Beer | The lyrics to the song 99 Bottles of Beer

Here's my code:

<?php    
    $bottles=99;
    $oneless=98;


    do {
        
        echo "$bottles bottles of beer on the wall, $bottles bottles of beer. <br />
            Take one down and pass it around, $oneless bottles of beer on the wall.<br /><br />";
        $bottles--;
        $oneless--;
        } while ($bottles>2);
    
    echo "$bottles bottles of beer on the wall, $bottles bottles of beer. <br />
            Take one down and pass it around,  $oneless bottle of beer on the wall.<br /><br />";
            $bottles--;
    echo "$bottles bottle of beer on the wall, $bottles bottle of beer. <br />
            Take one down and pass it around, no more bottles of beer on the wall.<br /><br />";
    echo "No more bottles of beer on the wall, no more bottles of beer. <br />
            Go to the store and buy some more, 99 bottles of beer on the wall.";    
?>

Do-while lang sa ako gigamit but naa moy masuggest nga better approach to make it simpler?
Murag bati kaayo tan-awon akong 3 echo statements sa last part of the code.

[fixyourself]

e recurse bai.. para choi.. or mas lisud e obfuscate...

[Metz]

e recurse bai.. para choi.. or mas lisud e obfuscate...

medyo advance pa for me. Ill get back to it if makaya na hehe.
Thanks.

[Chloe Sancel]

based on Time Complexity Ok ramn.. Basta as much as possible dili jud nested looping...

[Klave]

akong masuggest ra kay wala nay do....while na lang diretso
unya some if statements might allow you to remove your final echoes

count = 99;

while(count >= 0){
if(count == 0){
} else if(count == 1){
} else if(count == 2){
} else{
}
count--;
}

Final notes
Determine the common strings.
Take advantage of the fact that variables in PHP are mixed.
Some will prefer case or switch.
Wala ni nako gitest and didn't care to check syntax

[Metz]

akong masuggest ra kay wala nay do....while na lang diretso
unya some if statements might allow you to remove your final echoes

count = 99;

while(count >= 0){
if(count == 0){
} else if(count == 1){
} else if(count == 2){
} else{
}
count--;
}

Final notes
Determine the common strings.
Take advantage of the fact that variables in PHP are mixed.
Some will prefer case or switch.
Wala ni nako gitest and didn't care to check syntax

Thanks, daghan ga recommend nako ug for loops. ako nya ning balikan ug post with a for loop solution.

[Metz]

Another question:

naa koy code nakit-an nga drop down for time selection.

problem: create a drop down form where students will pick the time they sleep.
I googled a working sample code, ang problema lang kay di jud nako mapawork and end time ug 12 midnight. 11:59pm ra ako mabutang or walay output sa browser.

<?php
            $start = strtotime("8:00pm");
            $end = strtotime("11:59pm");

            echo '<select name="sleep">';
                for ($i = $start; $i <= $end; $i += 1800)
                    {
                    echo '<option>' . date('g:i a', $i);
                    }
                    echo '</select>';
            ?>

any suggestions?

[Klave]

One problem i see in your code is not ending your option tag.

My suggestion would be...use the alarm model for apple.
Rather than listing full time values in the drop down.
You can just make 3 dropdowns for hour, minute and ampm.
Then you can use the three values to get the appropriate time. (Naa ra function sa PHP)

[Metz]

One problem i see in your code is not ending your option tag.

My suggestion would be...use the alarm model for apple.
Rather than listing full time values in the drop down.
You can just make 3 dropdowns for hour, minute and ampm.
Then you can use the three values to get the appropriate time. (Naa ra function sa PHP)

nice bitaw apple na cloc, but medyo complicated pana para nako hehehe.
as for the option tag, considered bana as bad practice sa HTML?

PHP man gud ako primary tutorial then learn HTML as needed. Wa jud ko background HTML before.

[Klave]

What I meant was you opened an option (<option>) tag but did not close it (</option>).

Sayon ra man...

Without using <br> or new <div>

Loop from 1 to 12 or 1 to 24 the first drop down.
Loop from 00 to 59 the second drop down.
If you used 1 to 12 make another drop down with am or pm as values.

Then concatenate the selected values to make the date.